lokeshj1703 commented on a change in pull request #714: HDDS-1406. Avoid usage
of commonPool in RatisPipelineUtils.
URL: https://github.com/apache/hadoop/pull/714#discussion_r282971370
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelineFactory.java
##########
@@ -38,12 +38,12 @@
private Map<ReplicationType, PipelineProvider> providers;
PipelineFactory(NodeManager nodeManager, PipelineStateManager stateManager,
- Configuration conf) {
+ Configuration conf, RatisPipelineUtils ratisPipelineUtils) {
Review comment:
@bharatviswa504 Thanks for adding the changes! An instance of
RatisPipelineUtils does not seem right as it is a utility class. Could we move
the functions of RatisPipelineUtils to RatisPipelineProvider instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
