lokeshj1703 commented on a change in pull request #714: HDDS-1406. Avoid usage
of commonPool in RatisPipelineUtils.
URL: https://github.com/apache/hadoop/pull/714#discussion_r284609966
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelineFactory.java
##########
@@ -61,4 +61,13 @@ public Pipeline create(ReplicationType type,
ReplicationFactor factor,
List<DatanodeDetails> nodes) {
return providers.get(type).create(factor, nodes);
}
+
+ @VisibleForTesting
+ public PipelineProvider getProvider(ReplicationType type) {
Review comment:
We don't need to expose this api for now. In the test where it is used, we
can call pipelineManager.createPipeline instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
