steveloughran commented on a change in pull request #597: HDFS-3246: pRead
equivalent for direct read path
URL: https://github.com/apache/hadoop/pull/597#discussion_r269526676
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/CryptoInputStream.java
##########
@@ -62,9 +63,10 @@
@InterfaceAudience.Private
@InterfaceStability.Evolving
public class CryptoInputStream extends FilterInputStream implements
- Seekable, PositionedReadable, ByteBufferReadable, HasFileDescriptor,
- CanSetDropBehind, CanSetReadahead, HasEnhancedByteBufferAccess,
- ReadableByteChannel, CanUnbuffer, StreamCapabilities {
+ Seekable, PositionedReadable, ByteBufferReadable,
+ ByteBufferPositionedReadable, HasFileDescriptor, CanSetDropBehind,
+ CanSetReadahead, HasEnhancedByteBufferAccess, ReadableByteChannel,
+ CanUnbuffer, StreamCapabilities {
Review comment:
adding one extra interface shouldn't force reformatting this entire set of
lines -this only makes backporting on a common conflict point worse. Can you
just add the new interface and the end and leave the rest alone? thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
