steveloughran commented on a change in pull request #597: HDFS-3246: pRead
equivalent for direct read path
URL: https://github.com/apache/hadoop/pull/597#discussion_r269529072
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/CryptoInputStream.java
##########
@@ -741,6 +830,7 @@ public boolean hasCapability(String capability) {
case StreamCapabilities.DROPBEHIND:
case StreamCapabilities.UNBUFFER:
case StreamCapabilities.READBYTEBUFFER:
+ case StreamCapabilities.PREADBYTEBUFFER:
Review comment:
if you forward to another stream, yes, wrap it. Theres's ongoing work in
#575 to do more of this, with a matching PathCapabilities call for filesystems
so you can see if a file you open under a path will have the feature before you
open it (#568). These are both background bits of work so have languished
neglected, but I'd love to see them in. StreamCapabilities is in hadoop 2.9+
BTW, so while the features you can look for evolves, at least the client code
can compile without problems (and if you copy the new capabilities, link)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
