mira-silhavy commented on code in PR #1186:
URL: https://github.com/apache/wicket/pull/1186#discussion_r2167424604
##########
wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java:
##########
@@ -1986,7 +1986,7 @@ protected final void validateFormValidator(final
IFormValidator validator)
}
// check if the dependent component is visible
and is attached to
// the page
- else if (!dependent.isVisibleInHierarchy() ||
!dependent.isEnabledInHierarchy() || !dependent.isFormParticipant())
Review Comment:
Thinking about the test fix I did in the last commit, what do you think of a
case when `null` is being returned? Do you think it is a valid use case when a
developer would want to use FormValidator without any dependent component, e.g.
show error based on some condition in model data?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
