papegaaij commented on code in PR #1186:
URL: https://github.com/apache/wicket/pull/1186#discussion_r2152829467
##########
wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java:
##########
@@ -1986,7 +1986,7 @@ protected final void validateFormValidator(final
IFormValidator validator)
}
// check if the dependent component is visible
and is attached to
// the page
- else if (!dependent.isVisibleInHierarchy() ||
!dependent.isEnabledInHierarchy() || !dependent.isFormParticipant())
Review Comment:
I think this change looks good now. The warn below does need a small change,
and I think it would be a good idea to also log a warning where you put the
comment `// no enabled dependents, so no need to validate`. After all, the user
did add this validator to the form, so he/she probably expected it to do
something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
