mira-silhavy commented on code in PR #1186:
URL: https://github.com/apache/wicket/pull/1186#discussion_r2152208275
##########
wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java:
##########
@@ -1986,7 +1986,7 @@ protected final void validateFormValidator(final
IFormValidator validator)
}
// check if the dependent component is visible
and is attached to
// the page
- else if (!dependent.isVisibleInHierarchy() ||
!dependent.isEnabledInHierarchy() || !dependent.isFormParticipant())
Review Comment:
I've pushed the change, now the validation only happens if there's at least
1 enabled dependent component. If the array is null the validation is now also
skipped. Previously if the dependent form components was empty the validation
still occur.
##########
wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java:
##########
@@ -1986,7 +1986,7 @@ protected final void validateFormValidator(final
IFormValidator validator)
}
// check if the dependent component is visible
and is attached to
// the page
- else if (!dependent.isVisibleInHierarchy() ||
!dependent.isEnabledInHierarchy() || !dependent.isFormParticipant())
Review Comment:
I've pushed the change, now the validation only happens if there's at least
1 enabled dependent component. If the array is null the validation is now also
skipped. Previously if the dependent form components was empty the validation
still occurred.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
