[ 
https://issues.apache.org/jira/browse/TAP5-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792284#comment-17792284
 ] 

ASF subversion and git services commented on TAP5-2769:
-------------------------------------------------------

Commit ecb81b84719ffe72d4832075c4147f70476c8cd2 in tapestry-5's branch 
refs/heads/master from chrispoulsen
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=ecb81b847 ]

TAP5-2769 Upgrade ASM to 9.6 to allow running on Java 21 (#46)

* TAP5-2769 Upgrade ASM to 9.6 to allow running on Java 21

- Remove the copy of ASM
- Add project 'plastic-asm' to be the shadowed version of ASM 9.6
- Add a version property for ASM in the build

* TAP5-2769 Upgrade ASM to 9.6 to allow running on Java 21

- Inject a Tapestry specific TapestryAnnotationNode into ASM to get access to 
the static helper instead of relying on reflection

---------

Co-authored-by: Chris Poulsen <cpoul...@dezide.com>

> Upgrade ASM to 9.6 to allow running on Java 21
> ----------------------------------------------
>
>                 Key: TAP5-2769
>                 URL: https://issues.apache.org/jira/browse/TAP5-2769
>             Project: Tapestry 5
>          Issue Type: Task
>          Components: plastic
>    Affects Versions: 5.8.3
>            Reporter: Chris Poulsen
>            Priority: Major
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> I have a local version where the shadowing of ASM is done by Gradle to easier 
> maintain the ASM copy in the future.
> I'll create a PR with the changes on Github.
> The copied version had a single change to the ASM sources (in order to access 
> the static package protected method 
> {code:java}
> AnnotationNode.accept
> {code}
> .
> I did a quick hack with reflection to access it instead, there is definitely 
> room for improvement there, if anyone wants to take a stab at it.
> Edit: PR https://github.com/apache/tapestry-5/pull/46



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to