[ https://issues.apache.org/jira/browse/TAP5-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785803#comment-17785803 ]
Chris Poulsen commented on TAP5-2769: ------------------------------------- Btw. there are a few modules in the build that rely directly on the shadowed ASM code (my initial attempt was to make the shadowed ASM an "implementation" dependency of "plastic", but that broke things, so I changed it to "api" scope (making it transitive). If it is possible, it would probably make sense to try and eliminate the ASM exposure outside plastic (but I dont know if plastic is lacking some abstractions to do this, I have not have much direct contact with plastic in the past) > Upgrade ASM to 9.6 to allow running on Java 21 > ---------------------------------------------- > > Key: TAP5-2769 > URL: https://issues.apache.org/jira/browse/TAP5-2769 > Project: Tapestry 5 > Issue Type: Task > Components: plastic > Affects Versions: 5.8.3 > Reporter: Chris Poulsen > Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > I have a local version where the shadowing of ASM is done by Gradle to easier > maintain the ASM copy in the future. > I'll create a PR with the changes on Github. > The copied version had a single change to the ASM sources (in order to access > the static package protected method > {code:java} > AnnotationNode.accept > {code} > . > I did a quick hack with reflection to access it instead, there is definitely > room for improvement there, if anyone wants to take a stab at it. > Edit: PR https://github.com/apache/tapestry-5/pull/46 -- This message was sent by Atlassian Jira (v8.20.10#820010)