[
https://issues.apache.org/jira/browse/TAP5-2735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17592102#comment-17592102
]
Hudson commented on TAP5-2735:
------------------------------
SUCCESS: Integrated in Jenkins build Tapestry ยป tapestry-trunk-freestyle #157
(See
[https://ci-builds.apache.org/job/Tapestry/job/tapestry-trunk-freestyle/157/])
TAP5-2735: LocalizationSetter setNonPersistentLocaleFromRequest added (ben: rev
ccc3850012f81a99c7bfb1ab30b20985f37b5b00)
* (edit)
tapestry-core/src/test/java/org/apache/tapestry5/internal/services/ComponentEventDispatcherTest.java
* (edit)
tapestry-core/src/test/java/org/apache/tapestry5/internal/services/LocalizationSetterImplTest.java
* (edit)
tapestry-core/src/main/java/org/apache/tapestry5/internal/services/ComponentEventLinkEncoderImpl.java
* (edit)
tapestry-core/src/main/java/org/apache/tapestry5/services/LocalizationSetter.java
* (edit)
tapestry-core/src/test/java/org/apache/tapestry5/internal/services/ComponentEventLinkEncoderImplTest.java
* (edit)
tapestry-core/src/main/java/org/apache/tapestry5/internal/services/LocalizationSetterImpl.java
> LocalizationSetter should add "void setLocaleFromRequest(Request)"
> ------------------------------------------------------------------
>
> Key: TAP5-2735
> URL: https://issues.apache.org/jira/browse/TAP5-2735
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
> Affects Versions: 5.8.2
> Reporter: Ben Weidig
> Assignee: Ben Weidig
> Priority: Minor
>
> The LocalizationSetter is responsible for setting the correct Locale and
> provides an excellent extension/override point if you want to affect that,
> like we do in a multi-tenant/multi-language application.
> But component events fallback to the Request Locale if no other is available,
> which leads to wrong Locale detection in our case.
> The responsible void setLocaleFromRequest(Request) is a private method in
> org.apache.tapestry5.internal.services.ComponentEventLinkEncoderImpl which is
> not correct IMO.
> I propose moving the related code to the LocalizationSetter, so all
> Locale-related code is in a single interface and therefore modifiable by
> contributing a custom one.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
