[
https://issues.apache.org/jira/browse/TAP5-2735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17590625#comment-17590625
]
ASF subversion and git services commented on TAP5-2735:
-------------------------------------------------------
Commit ccc3850012f81a99c7bfb1ab30b20985f37b5b00 in tapestry-5's branch
refs/heads/master from Ben Weidig
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=ccc385001 ]
TAP5-2735: LocalizationSetter setNonPersistentLocaleFromRequest added
Request-based locale handling was previously in ComponentEventLinkEncoderImpl,
preventing any customization.
> LocalizationSetter should add "void setLocaleFromRequest(Request)"
> ------------------------------------------------------------------
>
> Key: TAP5-2735
> URL: https://issues.apache.org/jira/browse/TAP5-2735
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
> Affects Versions: 5.8.2
> Reporter: Ben Weidig
> Assignee: Ben Weidig
> Priority: Minor
>
> The LocalizationSetter is responsible for setting the correct Locale and
> provides an excellent extension/override point if you want to affect that,
> like we do in a multi-tenant/multi-language application.
> But component events fallback to the Request Locale if no other is available,
> which leads to wrong Locale detection in our case.
> The responsible void setLocaleFromRequest(Request) is a private method in
> org.apache.tapestry5.internal.services.ComponentEventLinkEncoderImpl which is
> not correct IMO.
> I propose moving the related code to the LocalizationSetter, so all
> Locale-related code is in a single interface and therefore modifiable by
> contributing a custom one.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
