singhvishalkr commented on PR #1123:
URL: https://github.com/apache/pulsar-site/pull/1123#issuecomment-4298660989
You were right on the CPP point -- trying to shoehorn every prebuilt into a
flat table was the wrong direction. Pushed `9c3317be` that takes the
row-expansion route you suggested.
Changes on this push:
- Reverted `src/components/OldReleaseTable.js` back to its pre-PR shape
(this PR no longer needs to touch the Pulsar-server / Pulsar-Manager tables at
all).
- Added `src/components/ClientReleasesTable.tsx`. Each client release row is
now:
- Collapsed: `Release | source tarball (asc, sha512) | Release notes`,
with an expand toggle in a leading cell.
- Expanded: shows the Apache archive directory URL for that version
(`archive.apache.org/dist/pulsar/pulsar-client-<lang>-${version}/`), which is
where every prebuilt lives, plus a short hint:
- CPP: "Pre-built DEB, RPM and APK packages (where published) live
alongside the source tarball in the directory above."
- Node: "Platform-specific napi prebuilts (darwin/linux/win, arm64/x64,
glibc/musl) are published alongside the source tarball in the directory above."
- Go and Python: no hint (source-only on dist).
- `CppReleasesDownloadTable`, `GoReleasesDownloadTable`,
`NodeReleasesDownloadTable`, `PythonReleasesDownloadTable` in `downloads.tsx`
now render through `ClientReleasesTable`. The original narrow bug (row link
pointing at the directory rather than the tarball) stays fixed because the
collapsed-row tarball link uses `tarPath` and the directory is only reached via
the explicit expand toggle.
Implementation: MUI `Collapse` + `IconButton` with the
`KeyboardArrowDown`/`Up` icons (both already listed in `package.json` under
`@mui/icons-material` and `@mui/material`). Each row keeps its own `useState`
so rows expand independently.
Local verification on this push (addressing the previous encoding footgun on
`c15b068`):
- `tsc --noEmit` across the project -- no new errors on
`ClientReleasesTable.tsx` or `downloads.tsx` (pre-existing errors in
`src/theme/Blog*/**` are unchanged, unrelated to this PR).
- SWC parse (`@swc/core` `transformSync` with `syntax: 'typescript', tsx:
true`) -- both files parse cleanly. This is the same loader that flagged
`c15b068` at position 1:1; running it locally catches the regression class that
blew up `c15b068` before I push.
- Blob byte check after push: first bytes of both files on the GitHub
contents API are `69 6D 70 6F 72 74` / no BOM / no UTF-16 markers.
If you'd rather have the collapsed state render the prebuilt hint inline
(e.g. next to the release notes column instead of gated behind expand), or want
the CPP table to list the per-distro binary paths inline once the naming
convention is stable enough to hardcode, I can iterate in a follow-up push.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
