singhvishalkr commented on PR #1123: URL: https://github.com/apache/pulsar-site/pull/1123#issuecomment-4297212659
Reshaped the client tables to match the Older releases layout -- @lhotari per your review. Two files changed on this push: - `src/components/OldReleaseTable.js`: the Binary column is now rendered only when at least one row has a `binary` field set. The existing callers for Pulsar server (`ArchivedPulsarDownloadTable`) and Pulsar Manager (`ArchivedPulsarManagerDownloadTable`) keep their 4-column layout (Release / Binary / Source / Release notes) because every row there has a binary tarball. When all rows are source-only, the component drops the Binary column and renders 3 columns instead. - `src/components/downloads.tsx`: `Cpp`/`Go`/`Node`/`Python` `ReleasesDownloadTable` now emit the `OldReleaseTable` shape (`source`, `sourceText`, `sourceAsc`, `sourceSha`, `sourceShaText`, `releaseNote`) instead of the flat `ReleaseTable` shape. For release notes I point at each client repo's GitHub releases tag (`https://github.com/apache/pulsar-client-<lang>/releases/tag/v<version>`) since that's the authoritative changelog for these projects (pulsar-site only has `release-notes/versioned/client-cpp-*.md` and `client-python-*.md` for some versions, nothing for `client-go`/`client-node`, so one consistent source keeps every row clickable). Note on the honest gap: Apache dist publishes source tarballs for all four clients and nothing else, so the Binary column would be empty for every row. I went with hiding the column rather than rendering empty cells; happy to switch to rendering a dash/placeholder if you'd rather keep the 4-column header for visual consistency with the Pulsar table above it. Also kept the original one-line fix (`link: url` -> `link: tarPath`) folded into the new data shape so the table entries still point at the actual `.tar.gz` rather than the directory. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
