singhvishalkr opened a new pull request, #1123:
URL: https://github.com/apache/pulsar-site/pull/1123

   ## Motivation
   
   Fixes #23836.
   
   Looking at 
[`src/components/downloads.tsx`](https://github.com/apache/pulsar-site/blob/main/src/components/downloads.tsx),
 the four client release tables — C++, Go, Node, Python — set 
`link: url`, where `url` is the Apache archive **directory** URL 
(`.../pulsar-client-cpp-X.Y.Z/`). The sibling `asc` and `sha512` fields 
correctly use `tarPath` (the tarball file).
   
   The result on 
[pulsar.apache.org/download](https://pulsar.apache.org/download/#old-releases) 
is a row where:
   
   | Column      | Resolves to                        |
   |-------------|------------------------------------|
   | Download    | directory listing (a UI of files)  |
   | asc         | `.tar.gz.asc`                      |
   | sha512      | `.tar.gz.sha512`                   |
   
   Which is exactly the mismatch the issue reports: *"The links under Pulsar 
C++ Client all point to directories, rather than individual files... The links 
should point to the files as per the asc and sha512 entries."*
   
   The same bug is present in the Go, Node, and Python tables — same line 
pattern, same function body. Fixing all four in one patch keeps the tables 
consistent.
   
   ## Modifications
   
   Change `link: url` → `link: tarPath` in:
   
   - `CppReleasesDownloadTable` (line 185 before patch)
   - `GoReleasesDownloadTable`  (line 204)
   - `NodeReleasesDownloadTable` (line 225)
   - `PythonReleasesDownloadTable` (line 245)
   
   ## Verifying this change
   
   Open `/download` in a built docs site — hovering/clicking the release 
name in the four client tables should now navigate to the 
`apache-pulsar-client-<lang>-<version>.tar.gz` file instead of the enclosing 
directory. `.asc` and `.sha512` columns are unchanged.
   
   ## Does this pull request potentially affect one of the following parts:
   
   - [x] `The docs`
   - [ ] Anything else
   
   ## Documentation
   
   - [x] `doc` &mdash; rendered download page.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to