oneby-wang commented on code in PR #25477:
URL: https://github.com/apache/pulsar/pull/25477#discussion_r3044454591
##########
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/PulsarClientSharedResourcesBuilder.java:
##########
@@ -119,4 +120,20 @@ PulsarClientSharedResourcesBuilder
configureThreadPool(SharedResource sharedReso
*/
PulsarClientSharedResourcesBuilder configureTimer(Consumer<TimerConfig>
configurer);
+ /**
+ * Configures the memory limit settings.
+ *
+ * @param configurer a consumer that configures the memory limit settings
+ * @return this builder instance for method chaining
+ */
+ PulsarClientSharedResourcesBuilder
configureMemoryLimitController(Consumer<MemoryLimitConfig> configurer);
+
+ /**
+ * Configures the open telemetry settings.
+ *
+ * @param configurer a consumer that configures the open telemetry settings
+ * @return this builder instance for method chaining
+ */
+ PulsarClientSharedResourcesBuilder
configureOpenTelemetry(Consumer<OpenTelemetry> configurer);
Review Comment:
Fixed.
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientSharedResourcesBuilderImpl.java:
##########
@@ -277,6 +313,18 @@ public PulsarClientSharedResourcesBuilder
configureTimer(Consumer<TimerConfig> c
return this;
}
+ @Override
+ public PulsarClientSharedResourcesBuilder
configureMemoryLimitController(Consumer<MemoryLimitConfig> configurer) {
+
configurer.accept(getOrCreateConfig(PulsarClientSharedResources.SharedResource.MemoryLimitController));
+ return this;
+ }
+
+ @Override
+ public PulsarClientSharedResourcesBuilder
configureOpenTelemetry(Consumer<OpenTelemetry> configurer) {
+
configurer.accept(getOrCreateConfig(PulsarClientSharedResources.SharedResource.OpenTelemetry));
+ return this;
+ }
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
