oneby-wang opened a new pull request, #25477: URL: https://github.com/apache/pulsar/pull/25477
Fixes https://github.com/apache/pulsar/issues/25212 ### Motivation https://github.com/apache/pulsar/issues/19074 enables sharing of Pulsar client resources across multiple isolated Pulsar client instances, but this solution lacks limiting the total amount of memory across all of the Pulsar client instances. This PR introduces a shared `MemoryLimitController` solution for PIP-234. ### Modifications 1. Modify `MemoryLimitController` to support registering multiple trigger callbacks and deregistering the callback when the client instance gets closed. 2. Add shared `MemoryLimitController` in `PulsarClientSharedResources` and `PulsarClientSharedResourcesBuilder`, then apply the shared `MemoryLimitController` to `PulsarClientImplBuilder`. 4. Add tests to verify the code change. ### Verifying this change - [x] Make sure that the change passes the CI checks. ### Does this pull request potentially affect one of the following parts: <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> *If the box was checked, please highlight the changes* - [ ] Dependencies (add or upgrade a dependency) - [x] The public API - [ ] The schema - [ ] The default values of configurations - [ ] The threading model - [ ] The binary protocol - [ ] The REST endpoints - [ ] The admin CLI options - [ ] The metrics - [ ] Anything that affects deployment ### Documentation <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> - [ ] `doc` <!-- Your PR contains doc changes. --> - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later --> - [x] `doc-not-needed` <!-- Your PR changes do not impact docs --> - [ ] `doc-complete` <!-- Docs have been already added --> ### Matching PR in forked repository PR in forked repository: https://github.com/oneby-wang/pulsar/pull/29 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
