oneby-wang commented on code in PR #25477:
URL: https://github.com/apache/pulsar/pull/25477#discussion_r3044438677
##########
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/PulsarClientSharedResources.java:
##########
@@ -71,7 +71,12 @@ enum SharedResource {
// pulsar-lookup threadpool
LookupExecutor(SharedResourceType.ThreadPool),
// DNS resolver and cache that must be shared together with
eventLoopGroup
- DnsResolver(SharedResourceType.DnsResolver);
+ DnsResolver(SharedResourceType.DnsResolver),
+ // pulsar client global memory limit controller
+ MemoryLimitController(SharedResourceType.MemoryLimitController),
+ // pulsar client global open telemetry instance
+ OpenTelemetry(SharedResourceType.OpenTelemetry)
Review Comment:
The `memoryLimitController` instance in `PulsarClientImpl` needs a
`memoryBufferStats` instance to expose metrics, so we need to inject a global
open telemetry instance here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
