vvivekiyer commented on code in PR #14917:
URL: https://github.com/apache/pinot/pull/14917#discussion_r1931000531
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/combine/BaseSingleBlockCombineOperator.java:
##########
@@ -111,7 +112,11 @@ protected void processSegments() {
@Override
protected void onProcessSegmentsException(Throwable t) {
_processingException.compareAndSet(null, t);
- _blockingQueue.offer(new ExceptionResultsBlock(t));
+ if (t instanceof BadQueryRequestException) {
Review Comment:
In ServerQueryExecutorV1Impl, we are setting `QUERY_VALIDATION_ERROR` for
`BadQueryRequestException`. Do we require the same changes here?
Either way I see this change only being made in
BaseSingleBlockCombineOperator. What about GroupByCombineOperator and
BaseStreamingCombineOperator?
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java:
##########
@@ -269,11 +271,17 @@ protected BrokerResponse handleRequest(long requestId,
String query, SqlNodeAndO
requestContext.setErrorCode(QueryException.EXECUTION_TIMEOUT_ERROR_CODE);
return new
BrokerResponseNative(QueryException.EXECUTION_TIMEOUT_ERROR);
} catch (Throwable t) {
+ ProcessingException queryException =
QueryException.QUERY_EXECUTION_ERROR;
+ if (t instanceof BadQueryRequestException) {
+ // provide more specific error code if available
+ queryException = QueryException.QUERY_VALIDATION_ERROR;
Review Comment:
We should update broker metrics - BrokerMeter.QUERY_VALIDATION_EXCEPTIONS ?
We should also update this in SingleStageBrokerRequestHandler?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
