real-mj-song opened a new pull request, #14917: URL: https://github.com/apache/pinot/pull/14917
Labels: - observability ## Description - When catching `BadQueryRequestException` in `ServerQueryExecutorV1Impl.java`, classify it as `QueryException.QUERY_VALIDATION_ERROR` instead of generic `QueryException.QUERY_EXECUTION_ERROR` since they are client side bad queries. - Throws `BadQueryRequestException` when aggregation functions fail to extract numeric type from given value ## Detailed reasoning Related to #14916 For some aggregation functions (sum/min/max), throws BadQueryRequestException instead of IllegalStateException because a non-numeric type is passed by client. An example of this is when the query is ``` SELECT SUM/MIN/MAX(Origin) FROM mytable WHERE AirlineID > 3000 ``` This fails with `IllegalStateException` and is classified as `QueryException.QUERY_EXECUTION_ERROR` by default by constructor of [`ExceptionResultsBlock`](https://github.com/apache/pinot/blob/master/pinot-core/src/main/java/org/apache/pinot/core/operator/blocks/results/ExceptionResultsBlock.java#L38-L40) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
