mqliang commented on code in PR #14536:
URL: https://github.com/apache/pinot/pull/14536#discussion_r1909247261


##########
pinot-integration-test-base/src/test/java/org/apache/pinot/integration/tests/ClusterTest.java:
##########
@@ -259,7 +259,9 @@ protected void startServers(int numServers)
       throws Exception {
     FileUtils.deleteQuietly(new File(TEMP_SERVER_DIR));
     for (int i = 0; i < numServers; i++) {
-      _serverStarters.add(startOneServer(i));
+      BaseServerStarter serverStarter = startOneServer(i);
+      _serverStarters.add(serverStarter);
+      _helixAdmin.enableInstance(getHelixClusterName(), 
serverStarter.getInstanceId(), true);

Review Comment:
   [SegmentStatusChecker.java 
L440](https://github.com/apache/pinot/pull/14536/files#diff-9ed38679d346d267a71767f40bb6e711e18ea544a243347297dd142b9e310f0aR440)
 check if a server is queryable by checking if `HELIX_ENABLED` set to true
   
   ```
     private boolean isServerQueryable(ServerQueryInfo serverInfo) {
       return serverInfo != null
           && serverInfo.isHelixEnabled()
           && !serverInfo.isQueriesDisabled()
           && !serverInfo.isShutdownInProgress();
     }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to