mqliang commented on PR #14536: URL: https://github.com/apache/pinot/pull/14536#issuecomment-2576026411
>Is this PR still WIP? I don't see the change related to checking instance assignment config @Jackie-Jiang we don't need to check instance assignment config specifically, if it has different number of replicas for OFFLINE & CONSUMING segments, we just need to avoid to use `minEVReplicas/maxISReplicas` as `PERCENT_OF_REPLICAS `, instead, we need to calculate the percentange for `OFFLINE` and `CONSUMING` specifically and emit the smaller one -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
