mqliang commented on code in PR #14536:
URL: https://github.com/apache/pinot/pull/14536#discussion_r1909867802
##########
pinot-integration-test-base/src/test/java/org/apache/pinot/integration/tests/ClusterTest.java:
##########
@@ -259,7 +259,9 @@ protected void startServers(int numServers)
throws Exception {
FileUtils.deleteQuietly(new File(TEMP_SERVER_DIR));
for (int i = 0; i < numServers; i++) {
- _serverStarters.add(startOneServer(i));
+ BaseServerStarter serverStarter = startOneServer(i);
+ _serverStarters.add(serverStarter);
+ _helixAdmin.enableInstance(getHelixClusterName(),
serverStarter.getInstanceId(), true);
Review Comment:
Updated.
##########
pinot-integration-test-base/src/test/java/org/apache/pinot/integration/tests/ClusterTest.java:
##########
@@ -259,7 +259,9 @@ protected void startServers(int numServers)
throws Exception {
FileUtils.deleteQuietly(new File(TEMP_SERVER_DIR));
for (int i = 0; i < numServers; i++) {
- _serverStarters.add(startOneServer(i));
+ BaseServerStarter serverStarter = startOneServer(i);
+ _serverStarters.add(serverStarter);
+ _helixAdmin.enableInstance(getHelixClusterName(),
serverStarter.getInstanceId(), true);
Review Comment:
Oh, I previously use
```
boolean helixEnabled = record.getBooleanField(
InstanceConfig.InstanceConfigProperty.HELIX_ENABLED.name(), false);
```
where default value is `false` that's why it was needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
