gortiz commented on code in PR #14345:
URL: https://github.com/apache/pinot/pull/14345#discussion_r1908441223


##########
pinot-common/src/test/java/org/apache/pinot/common/metrics/prometheus/dropwizard/DropwizardBrokerPrometheusMetricsTest.java:
##########
@@ -28,7 +31,7 @@
 /**
  * Disabling tests as Pinot currently uses Yammer and these tests fail for for 
{@link DropwizardMetricsFactory}
  */
-@Test(enabled = false)
+@Test(enabled = false) // enabled=false on class level doesn't seem to work in 
intellij

Review Comment:
   I'm not sure if we should modify our tests just because intellij doesn't 
honor some standard testng property.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to