gortiz commented on code in PR #14345:
URL: https://github.com/apache/pinot/pull/14345#discussion_r1908483109
##########
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/forward/FixedByteChunkSVForwardIndexTest.java:
##########
@@ -280,18 +271,15 @@ public void testDouble(ChunkCompressionType
compressionType, int version)
}
}
- try (ForwardIndexReader<ChunkReaderContext> fourByteOffsetReader = version
>= 4
- ? new FixedBytePower2ChunkSVForwardIndexReader(
- PinotDataBuffer.mapReadOnlyBigEndianFile(outFileFourByte),
DataType.DOUBLE)
- : new FixedByteChunkSVForwardIndexReader(
- PinotDataBuffer.mapReadOnlyBigEndianFile(outFileFourByte),
DataType.DOUBLE);
- ChunkReaderContext fourByteOffsetReaderContext = fourByteOffsetReader
- .createContext();
+ try (PinotDataBuffer buffer1 =
PinotDataBuffer.mapReadOnlyBigEndianFile(outFileFourByte);
+ ForwardIndexReader<ChunkReaderContext> fourByteOffsetReader = version
>= 4
+ ? new FixedBytePower2ChunkSVForwardIndexReader(buffer1,
DataType.DOUBLE)
+ : new FixedByteChunkSVForwardIndexReader(buffer1, DataType.DOUBLE);
+ ChunkReaderContext fourByteOffsetReaderContext =
fourByteOffsetReader.createContext();
Review Comment:
Thanks. I think the new format is quite better!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
