bziobrowski commented on PR #14345:
URL: https://github.com/apache/pinot/pull/14345#issuecomment-2504237571
Yes, PR can be reviewed. I added the annotations to disable tests when
running them in IntelliJ, which doesn't recognize following maven settings:
```
<!--Disabling tests as Pinot currently uses Yammer and these tests fail for
DropwizardMetricsFactory-->
<excludes>
<exclude>**/DropwizardBrokerPrometheusMetricsTest.java</exclude>
<exclude>**/DropwizardServerPrometheusMetricsTest.java</exclude>
<exclude>**/DropwizardMinionPrometheusMetricsTest.java</exclude>
<exclude>**/DropwizardControllerPrometheusMetricsTest.java</exclude>
</excludes>
```
I added a number of fixes to src/tests in pinot-segment-local to fix pinot
data buffer leaks.
I marked a few places that do not release resources in close() method with
"TODO:".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
