gortiz commented on code in PR #14727:
URL: https://github.com/apache/pinot/pull/14727#discussion_r1907575722
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MultistageGroupByExecutor.java:
##########
@@ -70,16 +70,15 @@ public class MultistageGroupByExecutor {
// because they use the zero based integer indexes to store results.
private final GroupIdGenerator _groupIdGenerator;
- public MultistageGroupByExecutor(
- int[] groupKeyIds,
- AggregationFunction[] aggFunctions,
- int[] filterArgIds,
- int maxFilterArgId,
- AggType aggType,
- boolean leafReturnFinalResult,
- DataSchema resultSchema,
- Map<String, String> opChainMetadata,
- @Nullable PlanNode.NodeHint nodeHint) {
+ public MultistageGroupByExecutor(int[] groupKeyIds,
+ AggregationFunction[] aggFunctions,
+ int[] filterArgIds,
+ int maxFilterArgId,
+ AggType aggType,
+ boolean leafReturnFinalResult,
+ DataSchema resultSchema,
+ Map<String, String> opChainMetadata,
+ @Nullable PlanNode.NodeHint nodeHint) {
Review Comment:
Could we keep the former style?
```
public MultistageGroupByExecutor(
int[] groupKeyIds,
AggregationFunction[] aggFunctions,
int[] filterArgIds,
int maxFilterArgId,
AggType aggType,
boolean leafReturnFinalResult,
DataSchema resultSchema,
Map<String, String> opChainMetadata,
```
I know there is no style restriction here, but this way is closer to what
both Kotlin and Scala do in their default styles and works better when having
very long types or variable names
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
