bziobrowski commented on code in PR #14727:
URL: https://github.com/apache/pinot/pull/14727#discussion_r1907474531
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MultistageGroupByExecutor.java:
##########
@@ -69,9 +70,16 @@ public class MultistageGroupByExecutor {
// because they use the zero based integer indexes to store results.
private final GroupIdGenerator _groupIdGenerator;
- public MultistageGroupByExecutor(int[] groupKeyIds, AggregationFunction[]
aggFunctions, int[] filterArgIds,
- int maxFilterArgId, AggType aggType, boolean leafReturnFinalResult,
DataSchema resultSchema,
- Map<String, String> opChainMetadata, @Nullable PlanNode.NodeHint
nodeHint) {
+ public MultistageGroupByExecutor(
+ int[] groupKeyIds,
+ AggregationFunction[] aggFunctions,
+ int[] filterArgIds,
+ int maxFilterArgId,
+ AggType aggType,
+ boolean leafReturnFinalResult,
+ DataSchema resultSchema,
+ Map<String, String> opChainMetadata,
+ @Nullable PlanNode.NodeHint nodeHint) {
Review Comment:
I was testing the waters. The formatter option I mentioned sometime ago
allows both but if name is long then pushing first arg to next line might be
better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
