bziobrowski commented on code in PR #14727:
URL: https://github.com/apache/pinot/pull/14727#discussion_r1907513482
##########
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/BrokerReduceService.java:
##########
@@ -70,12 +74,12 @@ public BrokerResponseNative reduceOnDataTable(BrokerRequest
brokerRequest, Broke
queryOptions != null &&
Boolean.parseBoolean(queryOptions.get(CommonConstants.Broker.Request.TRACE));
ExecutionStatsAggregator aggregator = new
ExecutionStatsAggregator(enableTrace);
- BrokerResponseNative brokerResponseNative = new BrokerResponseNative();
+ BrokerResponseNative response = new BrokerResponseNative();
// Cache a data schema from data tables (try to cache one with data rows
associated with it).
- DataSchema dataSchemaFromEmptyDataTable = null;
- DataSchema dataSchemaFromNonEmptyDataTable = null;
- List<ServerRoutingInstance> serversWithConflictingDataSchema = new
ArrayList<>();
+ DataSchema schemaOfEmptyTable = null;
+ DataSchema schemaOfNonEmptyTable = null;
+ List<ServerRoutingInstance> serversWithConflictingSchema = new
ArrayList<>();
Review Comment:
Reverted back to code with super-long var names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
