ankitsultana commented on code in PR #14501:
URL: https://github.com/apache/pinot/pull/14501#discussion_r1849566779
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/dispatch/timeseries/TimeSeriesDispatchClient.java:
##########
@@ -29,16 +29,19 @@
/**
* Dispatch client used to dispatch a runnable plan to the server.
- * TODO: This shouldn't exist and we should re-use DispatchClient. TBD as part
of multi-stage
+ * TODO(timeseries): This shouldn't exist and we should re-use DispatchClient.
TBD as part of multi-stage
* engine integration.
*/
public class TimeSeriesDispatchClient {
+ // TODO(timeseries): Note that time-series engine at present uses
QueryServer for data transfer from server to broker.
+ // This will be fixed as we integrate with MSE.
+ private static final int INBOUND_SIZE_LIMIT = 256 * 1024 * 1024;
Review Comment:
note: going through gRPC code and a demo to see if this can adverse perf
impact.
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/dispatch/timeseries/TimeSeriesDispatchClient.java:
##########
@@ -29,16 +29,19 @@
/**
* Dispatch client used to dispatch a runnable plan to the server.
- * TODO: This shouldn't exist and we should re-use DispatchClient. TBD as part
of multi-stage
+ * TODO(timeseries): This shouldn't exist and we should re-use DispatchClient.
TBD as part of multi-stage
* engine integration.
*/
public class TimeSeriesDispatchClient {
+ // TODO(timeseries): Note that time-series engine at present uses
QueryServer for data transfer from server to broker.
+ // This will be fixed as we integrate with MSE.
+ private static final int INBOUND_SIZE_LIMIT = 256 * 1024 * 1024;
Review Comment:
note: I am going through gRPC code and a demo to see if this can adverse
perf impact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
