ankitsultana commented on code in PR #14501:
URL: https://github.com/apache/pinot/pull/14501#discussion_r1852698292
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/timeseries/TimeSeriesAggregationOperator.java:
##########
@@ -129,6 +140,12 @@ protected TimeSeriesResultsBlock getNextBlock() {
throw new IllegalStateException(
"Don't yet support value expression of type: " +
valueExpressionBlockValSet.getValueType());
}
+ Preconditions.checkState(seriesBuilderMap.size() * (long)
_timeBuckets.getNumBuckets() <= _maxDataPointsLimit,
+ "Exceeded max data point limit per server. Limit: %s. Data points in
current segment so far: %s",
+ _maxDataPointsLimit, seriesBuilderMap.size() *
_timeBuckets.getNumBuckets());
+ Preconditions.checkState(seriesBuilderMap.size() <= _maxSeriesLimit,
+ "Exceeded max unique series limit per server. Limit: %s. Series in
current segment so far: %s",
+ _maxSeriesLimit, seriesBuilderMap.size());
}
Review Comment:
Nope our current plan is to fail the query altogether. We want to stay away
from partial results since showing warnings to the different user interfaces
ends up being quite complex and has a bunch of pitfalls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
