jackluo923 commented on code in PR #14365:
URL: https://github.com/apache/pinot/pull/14365#discussion_r1848924706
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java:
##########
@@ -525,6 +526,9 @@ public boolean index(GenericRow row, @Nullable RowMetadata
rowMetadata)
}
}
+ // NOTE: we must do this before we index a single column to avoid
partially indexing the row
Review Comment:
@chenboat
The current maximum is 1000 (default) entries for MV forward indexes because
the code paths which invokes the constructor almost always use the default
value. See
`org.apache.pinot.segment.local.segment.index.forward.ForwardIndexType#MAX_MULTI_VALUES_PER_ROW`
for the default value of 1000. See
`org.apache.pinot.segment.local.segment.index.forward.ForwardIndexType#createMutableIndex`
for the 2 places where MV mutable forward indexes is created with this 1000
max value limit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
