deemoliu commented on code in PR #14365:
URL: https://github.com/apache/pinot/pull/14365#discussion_r1842925372


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java:
##########
@@ -525,6 +526,9 @@ public boolean index(GenericRow row, @Nullable RowMetadata 
rowMetadata)
       }
     }
 
+    // NOTE: we msut do this before we index a single column to avoid 
partially indexing the row

Review Comment:
   this change seems affecting non-CLP logic, can you please eloborate why this 
change is needed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to