bziobrowski commented on code in PR #14298:
URL: https://github.com/apache/pinot/pull/14298#discussion_r1820366597
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/transformer/datetime/EpochToEpochTransformer.java:
##########
@@ -29,14 +31,20 @@
public class EpochToEpochTransformer extends BaseDateTimeTransformer<long[],
long[]> {
public EpochToEpochTransformer(DateTimeFormatSpec inputFormat,
DateTimeFormatSpec outputFormat,
- DateTimeGranularitySpec outputGranularity) {
- super(inputFormat, outputFormat, outputGranularity);
+ DateTimeGranularitySpec outputGranularity, @Nullable DateTimeZone
bucketingTz) {
+ super(inputFormat, outputFormat, outputGranularity, bucketingTz);
}
@Override
public void transform(@Nonnull long[] input, @Nonnull long[] output, int
length) {
- for (int i = 0; i < length; i++) {
- output[i] =
transformMillisToEpoch(transformToOutputGranularity(transformEpochToMillis(input[i])));
+ if (useCustomBucketingTimeZone()) {
Review Comment:
If time zone is set (even if utc) I'd rather stick to the more intuitive
datatime truncation approach than to revert to unintuitive one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
