gortiz commented on code in PR #14211:
URL: https://github.com/apache/pinot/pull/14211#discussion_r1797137662
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/MultiStageEngineIntegrationTest.java:
##########
@@ -1018,6 +1013,28 @@ public void testMVNumericCastInFilter() throws Exception
{
assertEquals(jsonNode.get("resultTable").get("rows").get(0).get(0).asInt(),
15482);
}
+ @Test
+ public void testFilteredAggregationWithNoValueMatchingAggregationFilter()
+ throws Exception {
+ // Write the query in a way where the aggregation will not be pushed to
the leaf stage, so that we can test the
+ // MultistageGroupByExecutor
Review Comment:
I think you can use the
[is_skip_leaf_stage_group_by](https://docs.pinot.apache.org/users/user-guide-query/multi-stage-query/operator-types/aggregate#is_skip_leaf_stage_group_by)
hint to do so
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/MultiStageEngineIntegrationTest.java:
##########
@@ -1018,6 +1013,28 @@ public void testMVNumericCastInFilter() throws Exception
{
assertEquals(jsonNode.get("resultTable").get("rows").get(0).get(0).asInt(),
15482);
}
+ @Test
+ public void testFilteredAggregationWithNoValueMatchingAggregationFilter()
+ throws Exception {
+ // Write the query in a way where the aggregation will not be pushed to
the leaf stage, so that we can test the
+ // MultistageGroupByExecutor
Review Comment:
nit: I think you can use the
[is_skip_leaf_stage_group_by](https://docs.pinot.apache.org/users/user-guide-query/multi-stage-query/operator-types/aggregate#is_skip_leaf_stage_group_by)
hint to do so
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
