yashmayya commented on PR #14211: URL: https://github.com/apache/pinot/pull/14211#issuecomment-2407369015
The PR description explains the rationale behind choosing different default behavior for the v1 and v2 query engines here. However, this currently means that there's no way to disable this behavior for the multi-stage query engine to improve query performance (and get non-standard behavior as a tradeoff). If we want to instead keep the behavior of the two query engines consistent, we have two options: - By default, always compute all groups for group by queries with only filtered aggregations. Add an option / performance hint to disable this behavior and improve query performance at the cost of non-standard behavior. The disadvantage of this option is that performance will suffer by default. - Keep the older behavior by default. Add an option to enable this standard SQL behavior of returning all groups at the cost of performance. The disadvantage of this is that the multi-stage query engine behavior in this case won't be SQL compliant by default (which is what we've been evolving it towards). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
