gortiz commented on code in PR #14211:
URL: https://github.com/apache/pinot/pull/14211#discussion_r1796977724
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MultistageGroupByExecutor.java:
##########
@@ -241,6 +241,11 @@ private void processAggregate(TransferableBlock block) {
aggFunction.aggregateGroupBySV(numMatchedRows, filteredIntKeys,
groupByResultHolder, blockValSetMap);
}
}
+ if (intKeys == null) {
+ // _groupIdGenerator should still have all the groups even if there
are only filtered aggregates for SQL
+ // compliant results.
+ generateGroupByKeys(block);
+ }
Review Comment:
Wouldn't be semantically the same to always initialize `intKeys` to
`generateGroupByKeys(block);` in line 209?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
