shounakmk219 commented on code in PR #13584: URL: https://github.com/apache/pinot/pull/13584#discussion_r1756734820
########## pinot-controller/src/main/java/org/apache/pinot/controller/validation/StorageQuotaChecker.java: ########## @@ -43,14 +44,19 @@ public class StorageQuotaChecker { private final ControllerMetrics _controllerMetrics; private final LeadControllerManager _leadControllerManager; private final PinotHelixResourceManager _pinotHelixResourceManager; + private final ControllerConf _controllerConf; + private final int _timeout; public StorageQuotaChecker(TableSizeReader tableSizeReader, ControllerMetrics controllerMetrics, LeadControllerManager leadControllerManager, - PinotHelixResourceManager pinotHelixResourceManager) { + PinotHelixResourceManager pinotHelixResourceManager, ControllerConf controllerConf) { _tableSizeReader = tableSizeReader; _controllerMetrics = controllerMetrics; _leadControllerManager = leadControllerManager; _pinotHelixResourceManager = pinotHelixResourceManager; + _controllerConf = controllerConf; Review Comment: Makes sense, will make the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org