mcvsubbu commented on code in PR #13584:
URL: https://github.com/apache/pinot/pull/13584#discussion_r1707957034
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/ControllerGauge.java:
##########
@@ -160,7 +160,8 @@ public enum ControllerGauge implements
AbstractMetrics.Gauge {
TABLE_DISABLED("tableDisabled", false),
- TABLE_REBALANCE_IN_PROGRESS("tableRebalanceInProgress", false);
+ TABLE_REBALANCE_IN_PROGRESS("tableRebalanceInProgress", false),
+ TABLE_STORAGE_QUOTA_EXCEEDED("tableStorageQuotaExceeded", true);
Review Comment:
We should not need a metric saying quota is exceeded. Instead, let us have a
metric that emits the percent of quota used by the table. Alerts can be set in
specific destinations on the value of this metric. Some installations can
choose to set the alert at 80%, others at 90%, etc. depending on the action
they want to take.
The value can also be greater than 100%, btw.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
