gortiz commented on code in PR #13598:
URL: https://github.com/apache/pinot/pull/13598#discussion_r1740950275


##########
pinot-query-runtime/src/test/java/org/apache/pinot/query/QueryServerEnclosure.java:
##########
@@ -112,7 +112,8 @@ public void shutDown() {
 
   public CompletableFuture<Void> processQuery(WorkerMetadata workerMetadata, 
StagePlan stagePlan,
       Map<String, String> requestMetadataMap) {
-    return CompletableFuture.runAsync(() -> 
_queryRunner.processQuery(workerMetadata, stagePlan, requestMetadataMap),
+    return CompletableFuture.runAsync(
+        () -> _queryRunner.processQuery(workerMetadata, stagePlan, 
requestMetadataMap, null),

Review Comment:
   QueryRunner.processQuery last argument is not annotated with Nullable so we 
should not call it with null. We need to either change the QueryRunner method 
signature or provide a value here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to