vrajat commented on code in PR #13598:
URL: https://github.com/apache/pinot/pull/13598#discussion_r1716278467
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/HashJoinOperator.java:
##########
@@ -260,6 +260,7 @@ private void buildBroadcastHashTable()
hashCollection.add(row);
Review Comment:
I did look into that. I chose to check for every block for a couple of
reasons.
- The block size is ~10000 rows which is very similar to the constant -
8192.
- It was easier to call this function after every block and not worry about
specific if-else & try-catch in every implementation.
In this specific case too, the hash table is being built and
sample/interruption will run every 10000 rows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
