gortiz commented on code in PR #13598:
URL: https://github.com/apache/pinot/pull/13598#discussion_r1740938387
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/HashJoinOperator.java:
##########
@@ -260,6 +260,7 @@ private void buildBroadcastHashTable()
hashCollection.add(row);
}
_currentRowsInHashTable += container.size();
+ sampleAndCheckInterruption();
Review Comment:
IICU We are only calling `sampleAndChekInterruption` when the hash table is
being build, but we should also call it whenever new blocks are received from
the left hand side. Specifically, we may be creating very large maps when using
cross join functions, but anyway the correct thing would be to call this method
on every join type whenever a block is being processed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
