rfscholte commented on code in PR #13854:
URL: https://github.com/apache/pinot/pull/13854#discussion_r1725408612


##########
.github/workflows/pinot_tests.yml:
##########
@@ -133,7 +133,7 @@ jobs:
           MAVEN_OPTS: >
             -Xmx2G -DskipShade -DfailIfNoTests=false 
-Dmaven.wagon.httpconnectionManager.ttlSeconds=25
             -Dmaven.wagon.http.retryHandler.count=30 -Dhttp.keepAlive=false 
-Dmaven.wagon.http.pool=false
-            -B -ntp
+            -B -ntp -P codecoverage

Review Comment:
   and that is true: `-B` is not a JVM options but an application argument, 
while `MAVEN_OPTS` should only contain JVM options. Makes me wonder how this 
could have ever worked.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to