rfscholte commented on code in PR #13854:
URL: https://github.com/apache/pinot/pull/13854#discussion_r1725111020
##########
pom.xml:
##########
@@ -2339,39 +2339,6 @@
</execution>
</executions>
</plugin>
- <plugin>
- <groupId>org.jacoco</groupId>
- <artifactId>jacoco-maven-plugin</artifactId>
- <version>0.8.12</version>
- <executions>
- <execution>
- <goals>
- <goal>prepare-agent</goal>
- </goals>
- </execution>
- <execution>
- <id>report</id>
- <phase>test</phase>
- <goals>
- <goal>report-aggregate</goal>
- </goals>
- <configuration>
- <includeCurrentProject>true</includeCurrentProject>
- </configuration>
- </execution>
- </executions>
- <configuration>
- <append>true</append>
- <includes>
- <include>org/apache/pinot/**/*</include>
- </includes>
- </configuration>
- </plugin>
- <plugin>
- <groupId>org.codehaus.mojo</groupId>
- <artifactId>sonar-maven-plugin</artifactId>
- <version>2.7.1</version>
- </plugin>
Review Comment:
AFAIK the sonar-plugin is only used to communicate with SonarQube, but if it
does more, the plugin should be moved to the codecoverage profile
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
