gortiz commented on code in PR #13854:
URL: https://github.com/apache/pinot/pull/13854#discussion_r1725097069
##########
pom.xml:
##########
@@ -2431,6 +2432,7 @@
<!-- Auto-generated target directories -->
<exclude>target/**</exclude>
<exclude>pinot-*/target/**</exclude>
+ <exclude>build/**</exclude> <!-- symbolic link pointing to
pinot/pinot-distribution/target/apache-pinot-1.3.0-SNAPSHOT-bin/apache-pinot-1.3.0-SNAPSHOT-bin
-->
Review Comment:
Note for reviewers: This symlink is not being understood by Windows, so the
license plugin consider it an actual file without valid license 😆
##########
pom.xml:
##########
@@ -2431,6 +2432,7 @@
<!-- Auto-generated target directories -->
<exclude>target/**</exclude>
<exclude>pinot-*/target/**</exclude>
+ <exclude>build/**</exclude> <!-- symbolic link pointing to
pinot/pinot-distribution/target/apache-pinot-1.3.0-SNAPSHOT-bin/apache-pinot-1.3.0-SNAPSHOT-bin
-->
Review Comment:
Note for reviewers: This symlink is not understood by Windows, so the
license plugin consider it an actual file without valid license 😆
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
