klsince commented on code in PR #13771:
URL: https://github.com/apache/pinot/pull/13771#discussion_r1724067958
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/QueryQuotaClusterIntegrationTest.java:
##########
@@ -169,14 +193,60 @@ private void runQueries(double qps, boolean shouldFail)
assertTrue((failCount == 0 && !shouldFail) || (failCount != 0 &&
shouldFail));
}
+ private void verifyQuotaUpdate(long quotaQps) {
+ String query = "SELECT COUNT(*) FROM " + getTableName();
+ if (quotaQps == 0) {
+ TestUtils.waitForCondition(aVoid ->
!executeQueryOnBroker(query).getExceptions().elements().hasNext()
Review Comment:
looks like the two stmts are same. is this intended to run the query twice
back to back?
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/QueryQuotaClusterIntegrationTest.java:
##########
@@ -169,14 +193,60 @@ private void runQueries(double qps, boolean shouldFail)
assertTrue((failCount == 0 && !shouldFail) || (failCount != 0 &&
shouldFail));
}
+ private void verifyQuotaUpdate(long quotaQps) {
+ String query = "SELECT COUNT(*) FROM " + getTableName();
+ if (quotaQps == 0) {
+ TestUtils.waitForCondition(aVoid ->
!executeQueryOnBroker(query).getExceptions().elements().hasNext()
Review Comment:
perhaps we can add a broker restful API to get runtime quotas for a table,
which can help simplify the test here and can be helpful for debugging in prod
as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
