Jackie-Jiang commented on code in PR #13771:
URL: https://github.com/apache/pinot/pull/13771#discussion_r1707533463
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/QueryQuotaClusterIntegrationTest.java:
##########
@@ -125,12 +132,15 @@ public void
testDatabaseQueryQuotaWithTableQueryQuotaWithExtraBroker()
addQueryQuotaToTableConfig(10);
// Add one more broker such that quota gets distributed equally among
them
brokerStarter = startOneBroker(2);
+ _brokerBaseApiUrl = LOCAL_HOST + ":" + brokerStarter.getPort();
// to allow change propagation to QueryQuotaManager
Thread.sleep(1000);
Review Comment:
Sleep is not robust, especially in the CI environment where machines have
very limited resource. One way to make it more robust is to use
`TestUtils.waitForCondition()` and keep trying until it meets the expectation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
