vrajat commented on code in PR #13816:
URL: https://github.com/apache/pinot/pull/13816#discussion_r1717831622
##########
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/DynamicBrokerSelector.java:
##########
@@ -112,7 +112,7 @@ public String selectBroker(String... tableNames) {
@Override
public List<String> getBrokers() {
- return _brokerList;
+ return _allBrokerListRef.get();
Review Comment:
> Was there a consumer of this method that relied on the list of ZK servers,
as returned previously?
There is no consumer in the Pinot code base. I dont know if external clients
use it. I verified with @Jackie-Jiang that this is a bug.
> Shall we return an immutable list of brokers?
I am keeping the PR as small as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
