soumitra-st commented on code in PR #13816: URL: https://github.com/apache/pinot/pull/13816#discussion_r1717249654
########## pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/DynamicBrokerSelector.java: ########## @@ -112,7 +112,7 @@ public String selectBroker(String... tableNames) { @Override public List<String> getBrokers() { - return _brokerList; + return _allBrokerListRef.get(); Review Comment: Shall we return an immutable list of brokers? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org