yashmayya commented on code in PR #13711: URL: https://github.com/apache/pinot/pull/13711#discussion_r1717908932
########## pinot-common/src/main/java/org/apache/pinot/common/function/scalar/comparison/PolymorphicComparisonScalarFunction.java: ########## @@ -0,0 +1,75 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.common.function.scalar.comparison; + +import javax.annotation.Nullable; +import org.apache.calcite.sql.type.ReturnTypes; +import org.apache.calcite.sql.type.SameOperandTypeChecker; +import org.apache.pinot.common.function.FunctionInfo; +import org.apache.pinot.common.function.PinotScalarFunction; +import org.apache.pinot.common.function.sql.PinotSqlFunction; +import org.apache.pinot.common.utils.DataSchema; + + +/** + * Base class for polymorphic comparison scalar functions + */ +public abstract class PolymorphicComparisonScalarFunction implements PinotScalarFunction { + + protected static final double DOUBLE_COMPARISON_TOLERANCE = 1e-7d; Review Comment: Looks like it is exact match which is why it isn't recommended to compare float / double values directly. In other standard databases users should either use some delta value explicitly themselves during comparison or else use the decimal / numeric types for exact precision comparison. I've pushed a commit with the suggested changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
