jasperjiaguo commented on PR #12969:
URL: https://github.com/apache/pinot/pull/12969#issuecomment-2067391315
> Is this the only places where the behavior is changed in #12712?
>
> To keep the exact same behavior and also keep most of the logic in the
root pom, we may add a property: `shade.active.by.default`
>
> @xiangfu0 Can you also take a look?
Tried using profile at the top level pom to configure this behaviour with
smth like
```
<profiles>
<profile>
<id>build-shaded-jar</id>
<activation>
<activeByDefault>${shade.active.by.default}</activeByDefault>
</activation>
<build>
<plugins>
<plugin>
<artifactId>maven-shade-plugin</artifactId>
...
```
but does not work, any suggestions? @Jackie-Jiang
Even setting ${shade.active.by.default} to true globally, shaded jars
doesn't install by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
